[Spice-devel] [vdagent-win RFC PATCH 0/5] Replace CxImage code

Frediano Ziglio fziglio at redhat.com
Wed Nov 9 10:45:28 UTC 2016


> 
> On Wed, Nov 09, 2016 at 10:32:40AM +0000, Frediano Ziglio wrote:
> > CxImage is used for image conversion for clipboard support.
> > CxImage have currently some issue:
> > - library is old and unsupported;
> > - required an old libpng library.
> > Currently the MingW binary we distribute due to some
> > issue have PNG disabled (so no clipboard image support).
> > Note that currently we support (before and after this patch)
> > only BMP and PNG. PNG is required as the default agent format.
> > However Windows programs wants to have BMP (specifically DIB)
> > in the clipboard.
> > This patch remove CxImage and use directly libpng (BMP is
> > supported directly by Windows APIs).
> > Tested with various formats and the compiled agent with a
> > Linux client.
> > The main concern is actually the possible problem to
> > support some weird/old BMP file formats.
> 
> Is there any sense in using gdk-pixbuf for image processing to
> enable support for formats beyond bmp/png ?
> 
> 
> Regards,
> Daniel

Actually I didn't find any Windows application that seems to
support other formats than DIB in the clipboard.
Would make sense for instance to avoid the conversion from
a Linux client of JPEG (perhaps reducing bandwidth) but
the conversion would happen on the guest anyway.
I also cannot find any agent capability for image formats
so it's not clear who and how the format is decided.
So I don't see much point in adding other formats.

Frediano


More information about the Spice-devel mailing list