[Spice-devel] [PATCH spice-server 4/5] syntax-check: Avoid unwanted autoconf replacements in Makefile.am

Christophe Fergeau cfergeau at redhat.com
Wed Nov 9 16:12:48 UTC 2016


nack, better to switch to --template rather than obfuscating this
generation even more.

On Wed, Nov 09, 2016 at 04:00:11PM +0000, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/Makefile.am | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/server/Makefile.am b/server/Makefile.am
> index ca67be1..3a0c71e 100644
> --- a/server/Makefile.am
> +++ b/server/Makefile.am
> @@ -1,4 +1,5 @@
>  NULL =
> +AT = @
>  SUBDIRS = . tests
>  
>  AM_CPPFLAGS =					\
> @@ -207,7 +208,7 @@ spice-server-enums.c: spice-server.h
>  			--fhead "#include \"spice-server-enums.h\"\n\n" \
>  			--fprod "\n#include \"spice-server.h\"\n" \
>  			--vhead "static const G at Type@Value _ at enum_name@_values[] = {" \
> -			--vprod "  { @VALUENAME@, \"@VALUENAME@\", \"@valuenick@\" }," \
> +			--vprod "  { $(AT)VALUENAME$(AT), \"$(AT)VALUENAME$(AT)\", \"@valuenick@\" }," \
>  			--vtail "  { 0, NULL, NULL }\n};\n\n" \
>  			--vtail "GType\n at enum_name@_get_type (void)\n{\n" \
>  			--vtail "  static GType type = 0;\n" \
> @@ -225,7 +226,7 @@ spice-server-enums.h: spice-server.h
>  			--fhead "G_BEGIN_DECLS\n\n" \
>  			--ftail "G_END_DECLS\n\n" \
>  			--ftail "#endif /* SPICE_SERVER_ENUMS_H */\n" \
> -			--eprod "#define SPICE_TYPE_ at ENUMSHORT@ @enum_name at _get_type()\n" \
> +			--eprod "#define SPICE_TYPE_$(AT)ENUMSHORT$(AT) @enum_name at _get_type()\n" \
>  			--eprod "GType @enum_name at _get_type (void);\n" \
>  		$^ >  $@
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161109/f304e4b4/attachment.sig>


More information about the Spice-devel mailing list