[Spice-devel] [PATCH spice-server 4/8] replay: Check properly version number
Jonathon Jongsma
jjongsma at redhat.com
Wed Nov 9 22:18:32 UTC 2016
Would be nice if we could somehow maintain backward compatibility, but
i don't think it's worth the effort to maintain it.
Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
On Fri, 2016-11-04 at 13:16 +0000, Frediano Ziglio wrote:
> 0 as version was never used so don't allow it
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
> server/red-replay-qxl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index 680e212..79e00e5 100644
> --- a/server/red-replay-qxl.c
> +++ b/server/red-replay-qxl.c
> @@ -1415,7 +1415,7 @@ SpiceReplay *spice_replay_new(FILE *file, int
> nsurfaces)
> spice_return_val_if_fail(file != NULL, NULL);
>
> if (fscanf(file, "SPICE_REPLAY %u\n", &version) == 1) {
> - if (version > 1) {
> + if (version != 1) {
> spice_warning("Replay file version unsupported");
> return NULL;
> }
More information about the Spice-devel
mailing list