[Spice-devel] [PATCH spice-server] build: Fix wrong -Wno-missing-field-initializers detection

[Christophe Fergeau]

On Wed, Nov 09, 2016 at 12:18:44PM -0500, Frediano Ziglio wrote:
> > 
> > Hey,
> > 
> > On Wed, Nov 09, 2016 at 09:13:32AM +0000, Frediano Ziglio wrote:
> > > The small code in m4/manywarnings.m4 wrongly detects if
> > > -Wno-missing-field-initializers is needed. This happens if
> > > -Wunused-variable is set. In this case the code fails to compile
> > > due to -Werror even if -Wno-missing-field-initializers would be
> > > perfectly fine.
> > 
> > This m4 macro comes from gnulib:
> > http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=m4/manywarnings.m4;h=89fd0ae38e387b9451fb62cb37936ccaefff3686;hb=HEAD#l55
> > so this would need to be fixed there first.
> > 
> > Christophe
> > 
> 
> Accepted and merged
> 
> http://git.savannah.gnu.org/cgit/gnulib.git/tree/m4/manywarnings.m4
> http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=94d81adc2f56c048b7872cd8ae2dd8568aef6dcf
> 
> Not sure we should update all the file too.
> I think the list of warnings will change.

I would update manywarnings.m4  to the latest version, we can blacklist
warnings we don't want from spice-compile-warnings.m4

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161110/227ad3f6/attachment.sig>