[Spice-devel] [PATCH spice-server 2/2] build: Disable some new added warnings

Christophe Fergeau cfergeau at redhat.com
Thu Nov 10 10:51:48 UTC 2016


On Thu, Nov 10, 2016 at 10:44:22AM +0000, Frediano Ziglio wrote:
> -Wshift-overflow cause an error to be detected in Glib headers.
> -Wformat-signedness and -Wnull-dereference probably could be
> fixed but currently they produce lot of errors.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  m4/manywarnings.m4 | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
> index 4f701f4..8b1ef3f 100644
> --- a/m4/manywarnings.m4
> +++ b/m4/manywarnings.m4
> @@ -140,7 +140,6 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC],
>      -Wformat-extra-args \
>      -Wformat-nonliteral \
>      -Wformat-security \
> -    -Wformat-signedness \
>      -Wformat-y2k \
>      -Wformat-zero-length \
>      -Wframe-address \
> @@ -176,7 +175,6 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC],
>      -Wnested-externs \
>      -Wnonnull \
>      -Wnonnull-compare \
> -    -Wnull-dereference \
>      -Wodr \
>      -Wold-style-declaration \
>      -Wold-style-definition \
> @@ -249,7 +247,6 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC],
>    # them here so that the above 'comm' command doesn't report a false match.
>    gl_manywarn_set="$gl_manywarn_set -Warray-bounds=2"
>    gl_manywarn_set="$gl_manywarn_set -Wnormalized=nfc"
> -  gl_manywarn_set="$gl_manywarn_set -Wshift-overflow=2"
>    gl_manywarn_set="$gl_manywarn_set -Wunused-const-variable=2"

nack, I believe they should be added to dontwarn in
spice-compile-warnings.m4

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161110/c712814a/attachment.sig>


More information about the Spice-devel mailing list