[Spice-devel] [PATCH spice-gtk] vncdisplaykeymap: Include missing headers

[Pavel Grunt]

On Mon, 2016-11-14 at 05:03 -0500, Frediano Ziglio wrote:
> > 
> > Causing build failures on win32
> >  .libs/vncdisplaykeymap.o: In function
> > `vnc_display_keymap_gdk2xtkbd_table':
> >   /builddir/build/BUILD/spice-gtk-0.33.19-
> > efbfd/build_win32/src/../../src/vncdisplaykeymap.c:198:
> >   undefined reference to `GDK_IS_WIN32_WINDOW'
> >  collect2: error: ld returned 1 exit status
> > 
> > Regression from 9ff67a108bb76e50a2c85a5054e6521088df1800
> > ---
> >  src/vncdisplaykeymap.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/src/vncdisplaykeymap.c b/src/vncdisplaykeymap.c
> > index d0c9739..2a79213 100644
> > --- a/src/vncdisplaykeymap.c
> > +++ b/src/vncdisplaykeymap.c
> > @@ -85,11 +85,15 @@ static unsigned int
> > ref_count_for_untranslated_keys = 0;
> >  #endif
> >  
> >  #ifdef GDK_WINDOWING_WIN32
> > +#include <gdk/gdkwin32.h>
> > +
> >  /* Win32 native virtual keycodes */
> >  #include "vncdisplaykeymap_win322xtkbd.c"
> >  #endif
> >  
> >  #ifdef GDK_WINDOWING_QUARTZ
> > +#include <gdk/gdkquartz.h>
> > +
> >  /* OS-X native keycodes */
> >  #include "vncdisplaykeymap_osx2xtkbd.c"
> >  #endif
> 
> Acked-by: Frediano Ziglio <fziglio at redhat.com>
> 
> Frediano
> 
thanks

> OT: I'm also getting
> 
> channel-usbredir.c:548:1: error:
> 'spice_usbredir_channel_get_spice_usb_device' defined but not used
> [-Werror=unused-function]
>  spice_usbredir_channel_get_spice_usb_device(SpiceUsbredirChannel
> *channel)
> 
> (probably as I have LZ4 disabled)

yes, that is the reason - should (? - looking at its definition) be
defined only with lz4

Pavel