[Spice-devel] [PATCH spice-server] Fix header include order for some files

Jonathon Jongsma jjongsma at redhat.com
Mon Nov 14 17:39:36 UTC 2016


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Mon, 2016-11-14 at 09:25 +0000, Frediano Ziglio wrote:
> Include common and libraries includes before local ones as
> stated by style.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/dcc-send.c       | 6 +++---
>  server/red-replay-qxl.c | 3 ++-
>  server/sound.c          | 2 +-
>  3 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/server/dcc-send.c b/server/dcc-send.c
> index 5f9ea45..e6505c8 100644
> --- a/server/dcc-send.c
> +++ b/server/dcc-send.c
> @@ -19,13 +19,13 @@
>  #include <config.h>
>  #endif
>  
> +#include <common/marshaller.h>
> +#include <common/generated_server_marshallers.h>
> +
>  #include "dcc-private.h"
>  #include "display-channel-private.h"
>  #include "red-channel-client-private.h"
>  
> -#include <common/marshaller.h>
> -#include <common/generated_server_marshallers.h>
> -
>  typedef enum {
>      FILL_BITS_TYPE_INVALID,
>      FILL_BITS_TYPE_CACHE,
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index c7c72fa..e72b8fd 100644
> --- a/server/red-replay-qxl.c
> +++ b/server/red-replay-qxl.c
> @@ -23,12 +23,13 @@
>  #include <inttypes.h>
>  #include <zlib.h>
>  #include <pthread.h>
> +#include <glib.h>
> +
>  #include "reds.h"
>  #include "red-qxl.h"
>  #include "red-common.h"
>  #include "memslot.h"
>  #include "red-parse-qxl.h"
> -#include <glib.h>
>  
>  #define QXLPHYSICAL_FROM_PTR(ptr) ((QXLPHYSICAL)(intptr_t)(ptr))
>  #define QXLPHYSICAL_TO_PTR(phy) ((void*)(intptr_t)(phy))
> diff --git a/server/sound.c b/server/sound.c
> index c0e8253..624585e 100644
> --- a/server/sound.c
> +++ b/server/sound.c
> @@ -28,6 +28,7 @@
>  
>  #include <common/marshaller.h>
>  #include <common/generated_server_marshallers.h>
> +#include <common/snd_codec.h>
>  
>  #include "spice.h"
>  #include "red-common.h"
> @@ -41,7 +42,6 @@
>  #include "red-channel-client-private.h"
>  #include "red-client.h"
>  #include "sound.h"
> -#include <common/snd_codec.h>
>  #include "demarshallers.h"
>  #include "main-channel-client.h"
>  


More information about the Spice-devel mailing list