[Spice-devel] [spice-gtk v2 3/3] win-usb-dev: improve warning message

Pavel Grunt pgrunt at redhat.com
Tue Nov 15 15:58:54 UTC 2016


On Tue, 2016-11-15 at 14:33 +0100, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> With the actual reason for failure. This might help to identify why
> code might be crashing or failing.
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  src/win-usb-dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/win-usb-dev.c b/src/win-usb-dev.c
> index 5e5bb4d..d5c2d91 100644
> --- a/src/win-usb-dev.c
> +++ b/src/win-usb-dev.c
> @@ -141,7 +141,7 @@ g_udev_client_list_devices(GUdevClient *self,
> GList **devs,
>      rc = libusb_get_device_list(priv->ctx, &lusb_list);
>      if (rc < 0) {
>          const char *errstr = spice_usbutil_libusb_strerror(rc);
> -        g_warning("%s: libusb_get_device_list failed", name);
> +        g_warning("%s: libusb_get_device_list failed due %s", name,
> errstr);
>          g_set_error(err, G_UDEV_CLIENT_ERROR,
> G_UDEV_CLIENT_LIBUSB_FAILED,
>                      "%s: Error getting device list from libusb: %s
> [%"G_GSSIZE_FORMAT"]",
>                      name, errstr, rc);

OT: the error messages should be translated if they are displayed

Pavel



More information about the Spice-devel mailing list