[Spice-devel] [PATCH spice-server v2 3/4] sound: Remove sin field from SpicePlaybackState and SpiceRecordState

[Jonathon Jongsma]

On Tue, 2016-11-15 at 11:23 +0100, Christophe Fergeau wrote:
> This would have deserved a "why?" in the log even if it's just a few
> lines (something like "it's redundant because all we need is sin->st
> which we can pass directly/get directly from yyy").
> 
> In my opinion, commits with only a short log are only acceptable
> for the most trivial of commits, which this one is not.
> 
> Christophe


I agree (even though I already acked the patch)

Jonathon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 847 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161115/971f08b1/attachment.sig>