[Spice-devel] [PATCH spice] Define G_LOG_DOMAIN

Pavel Grunt pgrunt at redhat.com
Wed Nov 16 14:56:44 UTC 2016


On Wed, 2016-11-16 at 09:26 -0500, Frediano Ziglio wrote:
> > 
> > Otherwise messages produced by g_{warn, return, ...} are not
> > prefixed
> > like the spice_{warn, return, ...} variants.
> > ---
> >  server/Makefile.am       | 1 +
> >  server/tests/Makefile.am | 1 +
> >  tools/Makefile.am        | 1 +
> >  3 files changed, 3 insertions(+)
> > 
> > diff --git a/server/Makefile.am b/server/Makefile.am
> > index 972f3e2..0a4847e 100644
> > --- a/server/Makefile.am
> > +++ b/server/Makefile.am
> > @@ -17,6 +17,7 @@ AM_CPPFLAGS =					
> > \
> >  	$(SSL_CFLAGS)				\
> >  	$(VISIBILITY_HIDDEN_CFLAGS)		\
> >  	$(WARN_CFLAGS)				\
> > +	-DG_LOG_DOMAIN=\"Spice\"		\
> >  	$(NULL)
> >  
> >  noinst_LTLIBRARIES = libserver.la
> > diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
> > index 37b9f88..8412876 100644
> > --- a/server/tests/Makefile.am
> > +++ b/server/tests/Makefile.am
> > @@ -12,6 +12,7 @@ AM_CPPFLAGS =					
> > \
> >  	$(SMARTCARD_CFLAGS)			\
> >  	$(SPICE_NONPKGCONFIG_CFLAGS)		\
> >  	$(SPICE_PROTOCOL_CFLAGS)		\
> > +	-DG_LOG_DOMAIN=\"Spice\"		\
> >  	$(NULL)
> >  
> >  if HAVE_AUTOMATED_TESTS
> > diff --git a/tools/Makefile.am b/tools/Makefile.am
> > index 03980c5..b2bfa2b 100644
> > --- a/tools/Makefile.am
> > +++ b/tools/Makefile.am
> > @@ -4,6 +4,7 @@ AM_CPPFLAGS = \
> >  	$(COMMON_CFLAGS) \
> >  	$(SPICE_PROTOCOL_CFLAGS) \
> >  	$(WARN_CFLAGS) \
> > +	-DG_LOG_DOMAIN=\"Spice\" \
> >  	$(NULL)
> >  
> >  AM_LDFLAGS = \
> 
> Cannot we use COMMON_CFLAGS in configure.ac ?
of course we can, I just used the same style as in spice-gtk

Pavel

> 
> Frediano


More information about the Spice-devel mailing list