[Spice-devel] [PATCH spice v3 1/3] Define G_LOG_DOMAIN

Christophe Fergeau cfergeau at redhat.com
Thu Nov 17 09:40:50 UTC 2016


On Wed, Nov 16, 2016 at 04:20:42PM +0100, Pavel Grunt wrote:
> Otherwise messages produced by g_{warn, return, ...} are not prefixed
> like the spice_ variants.
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 68aed15..caf9f4c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -127,6 +127,7 @@ dnl Check deps
>  
>  AC_CONFIG_SUBDIRS([spice-common])
>  COMMON_CFLAGS='-I ${top_srcdir}/spice-common/ -I ${top_builddir}/spice-common/'
> +COMMON_CFLAGS+=' -DG_LOG_DOMAIN=\"Spice\"'

Actually imo the Makefile.am version makes more sense, seeing this
snippet makes it fairly clear that "COMMON_CFLAGS" are the flags to use
for spice-common, and not really generic common flags to share between
all subdirectories.

Christophe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161117/871183a2/attachment-0001.sig>


More information about the Spice-devel mailing list