[Spice-devel] [vdagent-win PATCH 3/4] build: Automatically update version/copyright in version.rc

[Christophe Fergeau]

On Thu, Nov 17, 2016 at 12:15:03PM +0000, Frediano Ziglio wrote:
> The versions/copyright in version.rc are very outdated.
> Updating them automatically at configure time should ensure they are
> updated more often.
> Looks a bit weird to distribute config.h file however in this
> case it contain only version information and the file is
> useful to compile under Windows.
> 
> This patch is inspired by a work of Christophe Fergeau
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  Makefile.am       |  1 +
>  common/version.rc | 12 +++++++-----
>  configure.ac      |  6 ++++++
>  3 files changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 92e51e9..3962c3e 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -87,6 +87,7 @@ CLEANFILES = spice-vdagent-$(WIXL_ARCH)-$(VERSION)$(BUILDID).msi
>  
>  EXTRA_DIST +=			\
>  	$(top_srcdir)/.version	\
> +	config.h		\
>  	common/version.rc	\
>  	tests/clipboard.py	\
>  	vdagent.sln		\
> diff --git a/common/version.rc b/common/version.rc
> index e78a7ef..2603dce 100644
> --- a/common/version.rc
> +++ b/common/version.rc
> @@ -1,6 +1,8 @@
>  /////////////////////////////////////////////////////////////////////////////
>  // English (U.S.) resources
>  
> +#include "../config.h"

Is this #include "../config.h" working as expected for out of srctree
builds?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161117/0da3b1a1/attachment-0001.sig>