[Spice-devel] [vdagent-win PATCH 0/4] Update automatically version information

Christophe Fergeau cfergeau at redhat.com
Thu Nov 17 12:51:22 UTC 2016


Hey, thanks for the work on that, series looks good to me, only one
comment on patch 3

Apart from this comment,

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Thu, Nov 17, 2016 at 12:15:00PM +0000, Frediano Ziglio wrote:
> RC files contain version information.
> Update them based on git/configure version.
> 
> Patches work on both Windows using Visual Studio and Linux
> using MingW.
> 
> Frediano Ziglio (4):
>   Convert resource information to English
>   Move common resource code to a common file
>   build: Automatically update version/copyright in version.rc
>   build: Package zip file
> 
>  Makefile.am            |  2 ++
>  common/version.rc      | 51 +++++++++++++++++++++++++++++++++++++++++
>  configure.ac           |  8 ++++++-
>  vdagent/vdagent.rc     | 61 ++++++++++++++------------------------------------
>  vdservice/vdservice.rc | 61 ++++++++++++++------------------------------------
>  5 files changed, 94 insertions(+), 89 deletions(-)
>  create mode 100644 common/version.rc
> 
> -- 
> 2.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161117/1eca3442/attachment.sig>


More information about the Spice-devel mailing list