[Spice-devel] [PATCH spice-server] Avoid use after free

Pavel Grunt pgrunt at redhat.com
Fri Nov 18 09:54:23 UTC 2016


On Fri, 2016-11-18 at 09:38 +0000, Frediano Ziglio wrote:
> self->priv was deleted and then used
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  server/display-channel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/display-channel.c b/server/display-channel.c
> index 46191b0..52f0a3d 100644
> --- a/server/display-channel.c
> +++ b/server/display-channel.c
> @@ -79,8 +79,8 @@ display_channel_finalize(GObject *object)
>  
>      G_OBJECT_CLASS(display_channel_parent_class)->finalize(object);
>  
> -    g_free(self->priv);
>      g_array_unref(self->priv->video_codecs);
> +    g_free(self->priv);
>  }
>  
>  static void drawable_draw(DisplayChannel *display, Drawable
> *drawable);


More information about the Spice-devel mailing list