[Spice-devel] [vdagent-linux] vdagent: Fix udscs_read_callback memory ownership issue

Christophe Fergeau cfergeau at redhat.com
Wed Nov 23 15:35:31 UTC 2016


On Wed, Nov 23, 2016 at 03:03:48PM +0100, Victor Toso wrote:
> Hi,
> 
> On Wed, Nov 23, 2016 at 02:48:27PM +0100, Christophe Fergeau wrote:
> > Previous commit changed ownership rules for the data passed to the
> > udscs_read_callback, but forgot to update one of the user.
> > Both spice-vdagent and spice-vdagentd use an udscs_read_callback, either
> > from udscs_connect() or udscs_create_server().
> >
> > The previous commit only updated users of udscs_create_server(). This
> > caused memory corruption in spice-vdagent which uses udscs_connect().
> >
> > This fixes https://bugs.freedesktop.org/show_bug.cgi?id=98830
> 
> Looks good to me.
> Acked-by: Victor Toso <victortoso at redhat.com>

Thanks, pushed.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161123/04144208/attachment.sig>


More information about the Spice-devel mailing list