[Spice-devel] [PATCH v2 18/19] Free replay queues

Pavel Grunt pgrunt at redhat.com
Mon Nov 28 18:37:08 UTC 2016


On Fri, 2016-11-25 at 14:52 +0000, Frediano Ziglio wrote:
> There could be still some data pending.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  server/tests/replay.c | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/server/tests/replay.c b/server/tests/replay.c
> index 23d4125..8ec65d6 100644
> --- a/server/tests/replay.c
> +++ b/server/tests/replay.c
> @@ -302,6 +302,21 @@ static gboolean progress_timer(gpointer
> user_data)
>      return TRUE;
>  }
>  
> +static void free_queue(GAsyncQueue *queue)
> +{
> +    for (;;) {
> +        QXLCommandExt *cmd = g_async_queue_try_pop(queue);
> +        if (cmd == GINT_TO_POINTER(-1)) {
> +            continue;
> +        }
> +        if (!cmd) {
> +            break;
> +        }
> +        spice_replay_free_cmd(replay, cmd);
> +    }
> +    g_async_queue_unref(queue);
> +}
> +
>  int main(int argc, char **argv)
>  {
>      GError *error = NULL;
> @@ -440,9 +455,9 @@ int main(int argc, char **argv)
>          g_print("Counted %d commands\n", ncommands);
>  
>      spice_server_destroy(server);
> +    free_queue(display_queue);
> +    free_queue(cursor_queue);
>      end_replay();
> -    g_async_queue_unref(display_queue);
> -    g_async_queue_unref(cursor_queue);
>  
>      /* FIXME: there should be a way to join server threads before:
>       * g_main_loop_unref(loop);


More information about the Spice-devel mailing list