[Spice-devel] [PATCH spice-server 04/18] sound: Rename some objects

Christophe Fergeau cfergeau at redhat.com
Tue Nov 29 11:24:16 UTC 2016


On Wed, Nov 23, 2016 at 06:07:18PM +0000, Frediano Ziglio wrote:
> SndChannel -> SndChannelClient
> SndWorker -> SndChannel

I'd expect an explanation as to why what was called a SndChannel so far
really is a SndChannelClient (as it's going to inherit from
RedChannelClient in the future). Ditto for SndWorker->SndChannel

I'm wondering if things would be easier to follow if this was split
differently, ie one commit doing SndChannel->SndChannelClient and
renaming of 'channel' variables to 'client' and another commit doing
SndWorker->SndChannel + variable renaming.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161129/8af3de53/attachment.sig>


More information about the Spice-devel mailing list