[Spice-devel] [PATCH v3 00/17] Remove DummyChannel* objects

Frediano Ziglio fziglio at redhat.com
Tue Nov 29 14:57:00 UTC 2016


These objects were used by the sound channel as
this channel read/write to/from client directly.
This make the code of this channel quite different
from the other ones.
Also this reduce code duplication from RedChannelClient
and increase encapsulation.
First set of patches attempt to rename fields/structures
to prepare for the conversion to RedChannel/RedChannelClient
and GObject.
Than other patches basically do the conversion and
some cleanup.

Changes since v2:
- send playback data as soon as possible;
- split renames putting client renames first then worker ones;
- some commit message changes.

Changes since v1:
- split some long lines;
- do not attempt to free in progress frame before is full sent.
  This could cause raw frames to be overridden.

Frediano Ziglio (17):
  sound: Use worker directly
  sound: Rename SndChannel to SndChannelClient
  sound: Rename {Record,Playback}Channel to *ChannelClient
  sound: Rename channel to client if variable used for clients
  sound: Rename SndWorker to SndChannel
  sound: Rename workers to snd_channels
  sound: Rename worker to channel
  sound: Convert SndChannel to GObject
  sound: Implements config_socket RedChannel callback
  sound: Convert SndChannelClient to GObject
  sound: Implement on_disconnect RedChannel callback
  Remove DummyChannel* objects
  sound: Reduce message buffer
  Make RedChannelClient::incoming private
  sound: Free more on SndChannel finalize
  sound: Use default disconnect for client channels
  sound: Reuse code for snd_set_{playback,record}_peer

 server/Makefile.am                  |    4 +-
 server/dummy-channel-client.c       |  138 +--
 server/dummy-channel-client.h       |   64 +-
 server/dummy-channel.c              |   94 +--
 server/dummy-channel.h              |   60 +-
 server/red-channel-client-private.h |   11 +-
 server/red-channel-client.c         |   12 +-
 server/red-channel-client.h         |   13 +-
 server/sound.c                      | 1699 +++++++++++++---------------
 9 files changed, 857 insertions(+), 1238 deletions(-)
 delete mode 100644 server/dummy-channel-client.c
 delete mode 100644 server/dummy-channel-client.h
 delete mode 100644 server/dummy-channel.c
 delete mode 100644 server/dummy-channel.h

base-commit: 29d6642430a21eba53a11f5120590d13a857edf4
-- 
git-series 0.9.1


More information about the Spice-devel mailing list