[Spice-devel] [PATCH spice-server v2 0/7] Update proposed refactory merges

[Frediano Ziglio]

> 
> These patches (including the two extra fixups I sent) look fine to me,
> but I'll wait for somebody else to officially ACK them.
> 
> Jonathon
> 

Acked!

The RedChannelClient initialization order is quite different from
before but as it's mainly setup it's not a problem.
Particularly the header initialization is done as last so stuff
like config_socket could not send any messages now.
Also the client lock is held more then before.

I had a small conflict applying your last patches to the ones
contained in this set but was just the 100 characters patch
(spaces). I pushed my merge in
https://cgit.freedesktop.org/~fziglio/spice-server/log/?h=jj
(just to check everything is fine).

Frediano

> 
> On Fri, 2016-09-30 at 14:21 +0100, Frediano Ziglio wrote:
> > This patchset contains my split of the patches and some
> > proposed changes to the second big patch.
> > 
> > Frediano Ziglio (7):
> >   Split RedCharDeviceSmartcard and SmartCardChannelClient
> >   Convert RedChannelClient hierarchy to GObject
> >   fixup! Convert RedChannelClient hierarchy to GObject
> >   fixup! Convert RedChannelClient hierarchy to GObject
> >   fixup! Convert RedChannelClient hierarchy to GObject
> >   fixup! Convert RedChannelClient hierarchy to GObject
> >   fixup! Convert RedChannelClient hierarchy to GObject
> > 
> >  configure.ac                        |   4 +-
> >  server/Makefile.am                  |   4 +
> >  server/cursor-channel-client.c      |  74 +++--
> >  server/cursor-channel-client.h      |  34 ++-
> >  server/dcc-private.h                |  14 +-
> >  server/dcc.c                        | 201 +++++++++++--
> >  server/dcc.h                        |  37 ++-
> >  server/display-channel.c            |   4 +-
> >  server/dummy-channel-client.c       | 156 ++++++++++
> >  server/dummy-channel-client.h       |  59 ++++
> >  server/inputs-channel-client.c      |  56 ++--
> >  server/inputs-channel-client.h      |  47 ++-
> >  server/main-channel-client.c        | 146 ++++++++--
> >  server/main-channel-client.h        |  34 ++-
> >  server/red-channel-client-private.h |   4 +-
> >  server/red-channel-client.c         | 551 ++++++++++++++++++++++++
> > ------------
> >  server/red-channel-client.h         |  80 ++++--
> >  server/red-channel.h                |  31 +-
> >  server/smartcard-channel-client.c   | 415
> > +++++++++++++++++++++++++++
> >  server/smartcard-channel-client.h   | 108 +++++++
> >  server/smartcard.c                  | 374 ++++--------------------
> >  server/smartcard.h                  |  21 ++
> >  server/sound.c                      |   9 +-
> >  server/spice-server.h               |  16 ++
> >  server/spicevmc.c                   |   6 +-
> >  25 files changed, 1805 insertions(+), 680 deletions(-)
> >  create mode 100644 server/dummy-channel-client.c
> >  create mode 100644 server/dummy-channel-client.h
> >  create mode 100644 server/smartcard-channel-client.c
> >  create mode 100644 server/smartcard-channel-client.h
> > 
>