[Spice-devel] [PATCH] !fixup Use macros for casting Channel types

Jonathon Jongsma jjongsma at redhat.com
Tue Oct 11 20:24:40 UTC 2016


On Tue, 2016-10-11 at 10:00 -0400, Frediano Ziglio wrote:
> > 
>> Beside that... how to better handle all these fixup patches?
> I tend to prefer fixup patches for patch to big patches so
> it's easier to review and people don't have to do weird diff
> commands to understand what's changed from a version to another
> but possibly this causes problems to import back and merge.

I agree. It's nicer and allows you to see exactly what is being fixed.


> 
> Also, should all these fixup be acked or as minor issues
> could be merged if there are no feedback?
> 

I think it would be good to ack the fixup patches unless they were
*very* minor.

Jonathon


More information about the Spice-devel mailing list