[Spice-devel] [PATCH 0/7] Convert RedChannel to GObject

Jonathon Jongsma jjongsma at redhat.com
Tue Oct 11 22:28:56 UTC 2016


Here's a new version of the patch series that results in the RedChannel
hierarchy being converted to GObejct. In addition to fixes for issues that were
pointed out in the review, I also extracted a couple other private structs out
into separate patches. I also added a patch to fix a bug that I discovered
while splitting patches. Some of the code in the last patch is rearranged to
reduce the diff in the final patch a big and hopefully make it easier to
review. 

Jonathon Jongsma (7):
  Move CommonGraphicsChannel to a new file
  Use macros for casting Channel types
  Add CommonGraphicsChannelPrivate struct
  Add InputsChannelPrivate struct
  Don't increment num_clients_mig_wait twice
  Add MainChannelPrivate struct
  Convert RedChannel hierarchy to GObject

 server/Makefile.am                  |   4 +
 server/common-graphics-channel.c    | 202 +++++++++++
 server/common-graphics-channel.h    | 107 ++++++
 server/cursor-channel-client.c      |   3 +-
 server/cursor-channel.c             | 104 +++---
 server/cursor-channel.h             |  26 +-
 server/dcc-send.c                   |  13 +-
 server/dcc.c                        |  10 +-
 server/dcc.h                        |   2 +-
 server/display-channel-private.h    |  76 +++++
 server/display-channel.c            | 245 +++++++++++---
 server/display-channel.h            | 104 +++---
 server/dummy-channel-client.c       |  17 +-
 server/dummy-channel.c              |  49 +++
 server/dummy-channel.h              |  60 ++++
 server/inputs-channel-client.c      |   2 +-
 server/inputs-channel.c             | 187 ++++++-----
 server/inputs-channel.h             |  32 ++
 server/main-channel-client.c        |  64 ++--
 server/main-channel-client.h        |   5 +-
 server/main-channel.c               | 195 +++++++----
 server/main-channel.h               |  46 ++-
 server/red-channel-client-private.h |  19 ++
 server/red-channel-client.c         | 179 ++++++----
 server/red-channel-client.h         |   6 +-
 server/red-channel.c                | 649 ++++++++++++++++++++++++------------
 server/red-channel.h                | 183 +++++-----
 server/red-parse-qxl.h              |   2 +
 server/red-qxl.c                    |  21 +-
 server/red-replay-qxl.c             |   2 +-
 server/red-worker.c                 | 152 ++-------
 server/red-worker.h                 |  65 ----
 server/reds-private.h               |   3 +-
 server/reds.c                       |  66 ++--
 server/smartcard.c                  | 138 ++++++--
 server/sound.c                      |  44 ++-
 server/spicevmc.c                   | 450 +++++++++++++++++++------
 server/stream.c                     |   4 +-
 server/stream.h                     |   3 -
 39 files changed, 2402 insertions(+), 1137 deletions(-)
 create mode 100644 server/common-graphics-channel.c
 create mode 100644 server/common-graphics-channel.h
 create mode 100644 server/display-channel-private.h
 create mode 100644 server/dummy-channel.c
 create mode 100644 server/dummy-channel.h

-- 
2.7.4



More information about the Spice-devel mailing list