[Spice-devel] [PATCH spice-gtk v2 0/4]Add more tests for the session's uri

Marc-André Lureau mlureau at redhat.com
Wed Oct 12 15:38:08 UTC 2016


Hi

----- Original Message -----
> Hi,
> 
> I plan to merge both uri parsers (one is in spice-session, one in spice-uri).
> These patches add more to tests to avoid regressions.
> 
> v2 per Victor review splits IPv6 tests and checks for expected warnings
> v1: https://lists.freedesktop.org/archives/spice-devel/2016-May/029261.html

Reminds me of https://lists.freedesktop.org/archives/spice-devel/2015-March/019288.html

It's a shame to see glib so slow at picking the GUri patches. I personally lost interest, there are other better ways imho.

Tbh, instead of slowly reinventing YA URI parsing in C, I am tempted to go a step in the future and just link with the rust URI crate (https://docs.rs/url/1.2.1/url/). Since it's already being used by firefox in the latest release, I trust this is fairly solid.

I have done some mix of rust and C in the past, just like what Hub recently described in a blog: https://www.figuiere.net/hub/blog/?2016/10/07/862-rust-and-automake

It is fairly easy, and I would be happy to link with rust code which is way safer than C.

Of course, we would have to keep C for a while, but given that firefox depends on rust and Fedora ships it, gdb support it etc, there is a good chance it ends in every single platform we care about. 

> 
> Thanks,
> 
> Pavel Grunt (4):
>   test-session: Test alternative way for setting port
>   test-session: Also test hostname, username and password
>   test-session: Test invalid URIs
>   test-session: Add IPv6 tests
> 
>  tests/session.c | 266
>  +++++++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 242 insertions(+), 24 deletions(-)
> 
> --
> 2.10.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
> 


More information about the Spice-devel mailing list