[Spice-devel] [PATCH 4/7] Add InputsChannelPrivate struct

Jonathon Jongsma jjongsma at redhat.com
Wed Oct 12 20:34:57 UTC 2016


On Wed, 2016-10-12 at 06:55 -0400, Frediano Ziglio wrote:
> > 
> > 
> > Prepare for GObject port
> 
> Nacked
> 
> > 
> > ---
> >  server/inputs-channel.c | 68
> >  ++++++++++++++++++++++++++-----------------------
> >  1 file changed, 36 insertions(+), 32 deletions(-)
> > 
> > diff --git a/server/inputs-channel.c b/server/inputs-channel.c
> > index 85ca155..dfb7ba6 100644
> > --- a/server/inputs-channel.c
> > +++ b/server/inputs-channel.c
> > @@ -105,8 +105,7 @@ RedsState*
> > spice_tablet_state_get_server(SpiceTabletState
> > *st)
> >      return st->reds;
> >  }
> >  
> > -struct InputsChannel {
> > -    RedChannel base;
> > +typedef struct {
> >      uint8_t recv_buf[RECEIVE_BUF_SIZE];
> >      VDAgentMouseState mouse_state;
> >      int src_during_migrate;
> > @@ -115,6 +114,11 @@ struct InputsChannel {
> >      SpiceKbdInstance *keyboard;
> >      SpiceMouseInstance *mouse;
> >      SpiceTabletInstance *tablet;
> > +} InputsChannelPrivate;
> > +
> > +struct InputsChannel {
> > +    RedChannel base;
> > +    InputsChannelPrivate priv[1];
> >  };
> >  
> 
> Structure is already private.

Yes, that's true at the moment. But in the next patch the struct is
moved to the header.

Jonathon


More information about the Spice-devel mailing list