[Spice-devel] [PATCH spice-server] fixup! Move CommonGraphicsChannel to a new file

Pavel Grunt pgrunt at redhat.com
Fri Oct 14 10:39:54 UTC 2016


ACK

On Wed, 2016-10-12 at 11:52 +0100, Frediano Ziglio wrote:
> Do not include red-worker.h if not necessary.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/common-graphics-channel.h | 2 +-
>  server/cursor-channel.c          | 1 +
>  server/cursor-channel.h          | 1 +
>  3 files changed, 3 insertions(+), 1 deletion(-)
> 
> Beside this small patch, which basically move some hunks
> from following patches I ack the main one.
> 
> diff --git a/server/common-graphics-channel.h b/server/common-
> graphics-channel.h
> index 7b2aeff..b9473d8 100644
> --- a/server/common-graphics-channel.h
> +++ b/server/common-graphics-channel.h
> @@ -19,7 +19,7 @@
>  #define _COMMON_GRAPHICS_CHANNEL_H
>  
>  #include "red-channel.h"
> -#include "red-worker.h"
> +#include "red-channel-client.h"
>  
>  int common_channel_config_socket(RedChannelClient *rcc);
>  
> diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> index c73745f..1038a40 100644
> --- a/server/cursor-channel.c
> +++ b/server/cursor-channel.c
> @@ -26,6 +26,7 @@
>  #include "cursor-channel.h"
>  #include "cursor-channel-client.h"
>  #include "reds.h"
> +#include "red-qxl.h"
>  
>  typedef struct CursorChannelClient CursorChannelClient;
>  
> diff --git a/server/cursor-channel.h b/server/cursor-channel.h
> index a3ddaa3..bbc4868 100644
> --- a/server/cursor-channel.h
> +++ b/server/cursor-channel.h
> @@ -19,6 +19,7 @@
>  # define CURSOR_CHANNEL_H_
>  
>  #include "common-graphics-channel.h"
> +#include "red-parse-qxl.h"
>  
>  /**
>   * This type it's a RedChannel class which implement cursor (mouse)


More information about the Spice-devel mailing list