[Spice-devel] [PATCH spice] reds: Define openssl lock only if needed

Frediano Ziglio fziglio at redhat.com
Fri Oct 14 11:42:49 UTC 2016


> 
> Silence a warning:
>  reds.c:150:25: warning: 'lock_cs' defined but not used [-Wunused-variable]
>   static pthread_mutex_t *lock_cs;
> ---
>  server/reds.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/server/reds.c b/server/reds.c
> index 8dff12d..c69a653 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -147,7 +147,9 @@ static SpiceCoreInterfaceInternal core_interface_adapter
> = {
>  #define REDS_TOKENS_TO_SEND 5
>  #define REDS_VDI_PORT_NUM_RECEIVE_BUFFS 5
>  
> +#if OPENSSL_VERSION_NUMBER < 0x1010000FL
>  static pthread_mutex_t *lock_cs;
> +#endif
>  
>  /* TODO while we can technically create more than one server in a process,
>   * the intended use is to support a single server per process */

Perhaps would be worth moving inside the other #if
already present in the file?
Code is really local.

Frediano


More information about the Spice-devel mailing list