[Spice-devel] [spice-server PATCH 5/8] mjpeg_encoder_new: allocate memory after sanity check

[Frediano Ziglio]

> This patch prevents a leak in case the function returns early
> 
> Found by coverity.
> 
> Signed-off-by: Uri Lublin <uril at redhat.com>
> ---
>  server/mjpeg-encoder.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c
> index 1649516..d95c645 100644
> --- a/server/mjpeg-encoder.c
> +++ b/server/mjpeg-encoder.c
> @@ -1372,10 +1372,11 @@ VideoEncoder *mjpeg_encoder_new(SpiceVideoCodecType
> codec_type,
>                                  bitmap_ref_t bitmap_ref,
>                                  bitmap_unref_t bitmap_unref)
>  {
> -    MJpegEncoder *encoder = spice_new0(MJpegEncoder, 1);
> +    MJpegEncoder *encoder;
>  
>      spice_return_val_if_fail(codec_type == SPICE_VIDEO_CODEC_TYPE_MJPEG,
>      NULL);
>  
> +    encoder = spice_new0(MJpegEncoder, 1);
>      encoder->base.destroy = mjpeg_encoder_destroy;
>      encoder->base.encode_frame = mjpeg_encoder_encode_frame;
>      encoder->base.client_stream_report = mjpeg_encoder_client_stream_report;

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano