[Spice-devel] [PATCH spice-server 01/10] Define a compatibility include for GLib

[Frediano Ziglio]

> 
> On Tue, 2016-10-18 at 10:38 +0200, Francois Gouget wrote:
> > On Tue, 18 Oct 2016, Pavel Grunt wrote:
> > [...]
> > > > +#if !GLIB_CHECK_VERSION(2,30,0)
> > > > +static inline gboolean
> > > > +g_queue_remove_boolean(GQueue *queue, gconstpointer data)
> > > > +{
> > > > +	GList *link = g_queue_find(queue, data);
> > > > +	if (!link) {
> > > > +		return FALSE;
> > > > +	}
> > > > +	g_queue_unlink(queue, link);
> > > > +	return TRUE;
> > > > +}
> > > > +#define g_queue_remove g_queue_remove_boolean
> > > 
> > > glib changed the function ?
> > 
> > g_queue_remove() used to return void, thus causing a compilation
> > error
> > where we assigned / returned its value.
> > 
> I see, I don't like these api changes.. Even worse without updating
> the documentation for the function.
> 
> Ack for the patch
> 
> (I don't have a el6 machine where i could test these stuff)
> 
> Pavel
> 

https://github.com/GNOME/glib/commit/f065d7d60e2b6110705b1b32f050ccad0bcde62f

Frediano