[Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

[Jonathon Jongsma]

On Fri, 2016-10-14 at 10:49 -0400, Frediano Ziglio wrote:
> > 
> > From: Jonathon Jongsma <jjongsma at redhat.com>
> > 
> > Encapsulate MainChannel a bit better in preparation for proting to
> > GObject.
> 
> Small typo
> proting -> porting
> 

right

> > 
> > 
> > diff --git a/server/main-channel.h b/server/main-channel.h
> > index e0858d0..529e7be 100644
> > --- a/server/main-channel.h
> > +++ b/server/main-channel.h
> > @@ -78,7 +78,9 @@ void main_channel_migrate_switch(MainChannel
> > *main_chan,
> > RedsMigSpice *mig_targe
> >  int main_channel_migrate_connect(MainChannel *main_channel,
> > RedsMigSpice
> >  *mig_target,
> >                                   int try_seamless);
> >  void main_channel_migrate_cancel_wait(MainChannel *main_chan);
> > +const RedsMigSpice* main_channel_peek_migration_target(MainChannel
> > *main_chan);
> 
> Why not main_channel_get_migration_target ?
> Agreed with the const.

Yeah, I wanted to make it clear that the function doesn't transfer
ownership and the main channel still owns the returned object. But
there's not much precedent to using this terminology in spice server,
so it looks out-of-place. I'll change it to _get_

Jonathon