[Spice-devel] [PATCH] !fixup red-worker: Do not include not necessary red-channel-client.h

Jonathon Jongsma jjongsma at redhat.com
Thu Oct 20 14:14:41 UTC 2016


On Thu, 2016-10-20 at 06:10 -0400, Frediano Ziglio wrote:
> > 
> > 
> > ---
> > I need this additional change to get master to compile
> > 
> 
> That's weird. It always compiled for me and actually this
> patch does not apply.


Odd. This fixup applies on top of your other patch, which was applied
to a0fcf497 (which was origin/master at the time I applied it). 

Notice that red-qxl.c uses red_channel_client_get_channel() several
times, so I think it makes sense to include red-channel-client.h here,
no?


Jonathon


> 
> > 
> >  server/red-qxl.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/server/red-qxl.c b/server/red-qxl.c
> > index e517b41..fa51195 100644
> > --- a/server/red-qxl.c
> > +++ b/server/red-qxl.c
> > @@ -36,6 +36,7 @@
> >  #include "reds.h"
> >  #include "dispatcher.h"
> >  #include "red-parse-qxl.h"
> > +#include "red-channel-client.h"
> >  
> >  #include "red-qxl.h"
> >  
> 
> Frediano


More information about the Spice-devel mailing list