[Spice-devel] [PATCH spice-server] Remove g_smartcard_channel global
Frediano Ziglio
fziglio at redhat.com
Thu Oct 27 09:32:57 UTC 2016
>
> On Thu, Oct 27, 2016 at 05:21:03AM -0400, Frediano Ziglio wrote:
> > >
> > > I think I would have just switched this to a static variable, possibly a
> > > GOnce if you are worried about thread-safety.
> > >
> > > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > >
> > > Christophe
> > >
> >
> > This won't solve having 2 spice server instances on the same executable.
>
> If this is why you are doing this, this belongs in the commit log, and
> would avoid having a sad one line shortlog in that patch ;)
>
> Christophe
>
Sorry... already merged.
Well... removing global and put into a structure does not make much sense
if this structure is a singleton... it just slows down performance and
add additional dependencies...
Frediano
More information about the Spice-devel
mailing list