[Spice-devel] [PATCH spice-server v2] Remove red_pipe_add_verb family function

[Christophe Fergeau]

On Thu, Oct 27, 2016 at 12:39:02PM -0400, Frediano Ziglio wrote:
> > 
> > Hey,
> > 
> > On Wed, Oct 26, 2016 at 09:45:15AM +0100, Frediano Ziglio wrote:
> > > These functions were implementing the same stuff as empty
> > > messages functions provided by RedChannel so reuse them.
> > > 
> > > The implementation seems a bit different but the result
> > > is the same. Specifically:
> > > - RedEmptyMsgPipeItem::msg is int while RedVerbItem::verb was
> > >   uint16_t however this data goes into the message type which
> > >   is uint16_t (a 16 bit on the network protocol);
> > 
> > > - red_channel_client_send_empty_msg calls
> > >   red_channel_client_begin_send_message while red_marshall_verb
> > >   not. However red_marshall_verb calls are followed by either
> > 
> > I think you are missing a "does" -> "while red_marshall_verb does not"
> > 
> > >   cursor_channel_send_item or dcc_send_item which always
> > >   call red_channel_client_begin_send_message.
> > 
> > "always sent" I think.
> > 
> > >   Note that in dcc_send_item when an empty message is sent
> > >   red_channel_client_send_message_pending always returns
> > >   true;
> > 
> > I think this is not exactly true, the red_marshall_verb calls are done
> > from cursor_channel_send_item or dcc_send_item, which end with a call to
> > red_channel_client_begin_send_message()
> > 
> 
> dcc_send_item finish with
> 
>     // a message is pending
>     if (red_channel_client_send_message_pending(rcc)) {
>         begin_send_message(rcc);
>     }
> 
> in case of verb red_channel_client_send_message_pending returns true
> and begin_send_message just calls red_channel_client_begin_send_message
> as free_list->res->count is 0.
> 
> Should I rewrote this, maybe something like:
> 
>   Note that in dcc_send_item when an empty message is sent
>   red_channel_client_send_message_pending always returns
>   true and begin_send_message just calls red_channel_client_begin_send_message
>   as free_list->res->count is 0.
> 

This comment got quite bad too with some comments I added later :( 
"However red_marshall_verb calls are followed by either
cursor_channel_send_item or dcc_send_item which always
call red_channel_client_begin_send_message."

This is saying that we have a call to red_marshall_verb, and then a call
to cursor_channel_send_item or dcc_send_item, while the
red_marshall_verb calls currently are within these send_item functions.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161028/4f8a7f91/attachment.sig>