[Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

[Victor Toso]

On Thu, Sep 01, 2016 at 11:22:52AM +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Aug 31, 2016 at 11:54:41AM -0500, Jonathon Jongsma wrote:
> > Prepare to port to GObject by encapsulating all private data
>
> If I'm not mistaken, the private struct now will leak while
> SmartCardChannelClient is not a GObject with its finalize/dispose.
> If that is the case, might point it out in the commit log and/or a FIXME
> on g_new0
>
> Besides that, looks ok to me.
> Reviewed-by: Victor Toso <victortoso at redhat.com>

Comment might apply to patches 06 and 07 too