[Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

Thu Sep 1 15:17:11 UTC 2016

> > On 1 Sep 2016, at 18:08 PM, Frediano Ziglio < fziglio at redhat.com > wrote:
> 

> > > > On 1 Sep 2016, at 17:27 PM, Christophe Fergeau < cfergeau at redhat.com >
> > > > wrote:
> > > 
> > 
> 

> > > > On Thu, Sep 01, 2016 at 05:11:06PM +0300, Dmitry Fleytman wrote:
> > > 
> > 
> 

> > > > > Does this answer your questions?
> > > > 
> > > 
> > 
> 

> > > > I think what Frediano is after is a public Daynix-maintained git
> > > 
> > 
> 
> > > > repository with the patches you are sending applied, as it's not always
> > > 
> > 
> 
> > > > easy to git am these big series (CR/LR differences, not always 100%
> > > 
> > 
> 
> > > > clear on what commit they should apply on, ...). Is there such a
> > > 
> > 
> 
> > > > publicly accessible repository, which would make patch reviews easier?
> > > 
> > 
> 

> > > Currently such a repository does not exist. We will create one and post
> > > to
> > 
> 
> > > the list.
> > 
> 

> > Sorry Dmitry but you said that we agree on
> 

> > https://gitlab.com/spice/qxl-wddm-dod - the new main one - we expect that
> > our
> > patches will be applied to this repository
> 

> > but than the patches you are sending does not apply and we still need
> > another
> > repo.
> 
> > Is it not a contradiction?
> 

> Our patches should apply cleanly, our internal branches are based on this
> repository.
> Is it due to CR/LF differences or something else?

For instance they change some files that does not exist anymore. 

Frediano 

> > Frediano
> 

> > > > Christophe
> > > 
> > 
> 

> > > > > Best Regards,
> > > > 
> > > 
> > 
> 
> > > > > Dmitry
> > > > 
> > > 
> > 
> 

> > > > > > On 1 Sep 2016, at 16:12 PM, Frediano Ziglio < fziglio at redhat.com >
> > > > > > wrote:
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Hi,
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > sorry for the latency.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > However there are some base problems on these patches. One big one
> > > > > > it's
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > the repository. As this is not public once we ack the patches where
> > > > > > are
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > you putting them? Just changing the comment on the private branch?
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Actually there are multiple repositories public:
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > 1- https://github.com/vrozenfe/qxl-dod ,
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > < https://github.com/vrozenfe/qxl-dod, > original one
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > 2- https://gitlab.com/spice/qxl-wddm-dod/commits/master
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > < https://gitlab.com/spice/qxl-wddm-dod/commits/master >, a copy on
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > gitlab, not sure if this is supposed to be the main one, actually
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > commits are identical to 1
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > 3- https://github.com/flexVDI/qxl-dod
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > < https://github.com/flexVDI/qxl-dod >, FlexVDI additional patches,
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > contains 1/2 + additions.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Personally I pushed the common patches in
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > https://cgit.freedesktop.org/spice/win32/qxl-wddm-dod/
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > <https://cgit.freedesktop.org/spice/win32/qxl-wddm-dod/>. Can you
> > > > > > access
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > it?
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Another problem is the ownership of the patches. Some changes are
> > > > > > inside
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > FlexVDI patches, merged possibly to other ones and with a different
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > owner. One example is the new delete operator from Javier. These
> > > > > > issue
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > should be fixed. Still doing on a private branch is quite difficult
> > > > > > and
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > not in line with OpenSource.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > I contacted Vadim asking for the state of its GitHub repository and
> > > > > > said
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > the beside the last patch the state is fine, I think we should
> > > > > > start
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > from that commit
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > (https://github.com/vrozenfe/qxl-dod/commit/4e1b33dd4d4f9bb5ee58d13c2a88f8ed610afc41
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > <https://github.com/vrozenfe/qxl-dod/commit/4e1b33dd4d4f9bb5ee58d13c2a88f8ed610afc41>)
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > which is also included in your private repository.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > To sum up: We _need_ the common public main repository.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Frediano
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > From: "Sameeh Jubran" <sameeh at daynix.com>
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > To: "Spice List" <spice-devel at lists.freedesktop.org>
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Cc: "Dmitry Fleytman" <dmitry at daynix.com>, "Frediano Ziglio"
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > <fziglio at redhat.com>
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Sent: Tuesday, August 30, 2016 1:18:19 PM
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Subject: Re: [PATCH qxl-wddm-dod 00/26] Win10 support patches
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Can anyone review the rest of the patches? (8 - 26)
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > On Wed, Aug 24, 2016 at 4:22 PM, Sameeh Jubran <sameeh at daynix.com
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > <mailto:sameeh at daynix.com>> wrote:
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Can you please review the rest of the patches so I can send v2?
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > On Tue, Aug 9, 2016 at 6:28 PM, Sameeh Jubran <sameeh at daynix.com
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > <mailto:sameeh at daynix.com>> wrote:
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > This series contains the latest patches to support Windows 10.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Visual Studio 2015 with Win10 WDK is required to compile this code,
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Current patches may be compiled and will work for Windows 10.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Smoke testing had been done in windows 8.1 seems to be working
> > > > > > good.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Dmitry Fleytman (4):
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Replacing <#ifdef USE_FRAMEBUFFER> with runtime logic
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Fixing framebuffer usage logic
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Support future Qxl revisions
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Set SupportNonVGA in QueryAdapterInfo callback
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Sameeh Jubran (9):
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Upgrade to Windows 10 WDK
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Add delete operator
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Code Analysis clean up
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Replacing tabs with spaces
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Fix source buffer mapping in PresentDisplayOnly
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Fixing Move rectangles implementation
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Reserved must be set to 0
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Fixing monitor flicker on resolution change
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Removing unnecessary call to BlackOutScreen
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Sandy Stutsman (13):
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Add printer class to dump debug print statements to kernel debugger
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > output
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Set DriverStarted flag at the begining of the StartDriver function
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Fix Code Integrity error generated by the Drive Verifier
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Add functions called from non-pageable functions to non-paged
> > > > > > segments
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Do not use virtual functions for code that must not be paged
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > On power wake call the init functions before setting the vidpn to
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > black. Otherwise, BSOD.
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Use SrcPitch when calculating size of memory to map
> > > > > > PresentDisplayOnly
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Remove unused notify present display only interrupt and fix
> > > > > > interrupt
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > mask
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Add arbitrary resolution and monitors_config Escape
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Use the second bar (VRAM) for qxl command buffer.
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Comment out frame buffer mapping.
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Enable HW cursor support and fix handling of monochrome cursors.
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Remove minimum size restrict for custom resolution.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > Tools/vs_cmdline.vbs | 23 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Tools/vs_run.bat | 26 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > buildAll.bat | 15 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > buildAll_NoSign.bat | 19 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod Package/qxldod Package.vcxproj | 173 +-
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod Package/qxldod Package.vcxproj.user | 15 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod.sln | 106 +-
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/BaseObject.cpp | 11 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/BaseObject.h | 1 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/QxlDod.cpp | 1280 +++++++++------
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/QxlDod.h | 67 +-
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/buildAll.bat | 31 -
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/callVisualStudio.bat | 28 -
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/checkWin8Tools.bat | 8 -
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/clean.bat | 12 -
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/driver.cpp | 26 +-
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/driver.h | 20 +-
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/include/qxl_windows.h | 1 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/mspace.c | 2437
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > ---------------------------
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/mspace.cpp | 2439
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > ++++++++++++++++++++++++++++
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/qxldod.vcxproj | 247 ++-
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/qxldod.vcxproj.filters | 2 +-
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > qxldod/qxldod.vcxproj.user | 15 +
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > 23 files changed, 3619 insertions(+), 3383 deletions(-)
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > create mode 100644 Tools/vs_cmdline.vbs
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > create mode 100644 Tools/vs_run.bat
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > create mode 100644 buildAll.bat
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > create mode 100644 buildAll_NoSign.bat
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > create mode 100644 qxldod Package/qxldod Package.vcxproj.user
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > delete mode 100755 qxldod/buildAll.bat
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > delete mode 100755 qxldod/callVisualStudio.bat
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > delete mode 100755 qxldod/checkWin8Tools.bat
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > delete mode 100755 qxldod/clean.bat
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > delete mode 100755 qxldod/mspace.c
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > create mode 100644 qxldod/mspace.cpp
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > create mode 100644 qxldod/qxldod.vcxproj.user
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > --
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > 2.7.0.windows.1
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > --
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Respectfully,
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Sameeh Jubran
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Junior Software Engineer @ Daynix <http://www.daynix.com/>.
> > > > > 
> > > > 
> > > 
> > 
> 

> > > > > > --
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Respectfully,
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Sameeh Jubran
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>
> > > > > 
> > > > 
> > > 
> > 
> 
> > > > > > Junior Software Engineer @ Daynix <http://www.daynix.com/>.
> > > > > 
> > > > 
> > > 
> > 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160901/76a76afb/attachment-0001.html>