[Spice-devel] [PATCH 02/10] Move RedChannelClient to separate file

[Christophe Fergeau]

On Thu, Sep 01, 2016 at 01:54:13PM -0500, Jonathon Jongsma wrote:
> 
> > > diff --git a/server/red-channel.c b/server/red-channel.c
> > > index bf290b1..03338aa 100644
> > > --- a/server/red-channel.c
> > > +++ b/server/red-channel.c
> > > @@ -2179,11 +707,7 @@ void
> > > red_client_semi_seamless_migrate_complete(RedClient *client)
> > >      link = client->channels;
> > >      while (link) {
> > >          next = link->next;
> > > -        RedChannelClient *rcc = link->data;
> > > -
> > > -        if (rcc->latency_monitor.timer) {
> > > -            red_channel_client_start_ping_timer(rcc,
> > > PING_TEST_IDLE_NET_TIMEOUT_MS);
> > > -        }
> > > +        red_channel_client_semi_seamless_migration_complete(link-
> > > >data);
> > 
> > Non-obvious name given the code it replaces, but I guess you
> > double-checked that's a good name?
> > 
> 
> 
> I see your point.

Ah, and looking at this again, I see where the name is coming from now.
Initially, I was only looking at the code (which starts a 'ping timer'),
and not seeing the link with semi_seamless_migration_complete(). Now I
see that this code was part of a method named
red_client_semi_seamless_migrate_complete() so it makes more sense ;)
I guess the name is good!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160902/cef30c92/attachment.sig>