[Spice-devel] [PATCH 1/6] [spice-proto] Add support to ssh channel

[Fabiano Fidêncio]

On Sat, Sep 3, 2016 at 2:29 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> On Sat, Sep 3, 2016 at 2:02 PM, Victor Toso <lists at victortoso.com> wrote:
>> Hi,
>>
>> On Sat, Sep 03, 2016 at 01:49:07PM +0200, Fabiano Fidêncio wrote:
>>> ---
>>
>> Could you please include some documentation about the protocol in the
>> commit log? Check webdav ~ 6e5ea8d802ac8 or port ~ f188fb7a89086
>
> Okay, I'll send a v2 at some point (already switched context to Sagar's work).
> I hope it doesn't block you from reviewing the patches. In any case,
> let me try to help you to help me :-)
>
> Here you can find the protocol description:
> https://tools.ietf.org/html/draft-ietf-secsh-agent-02

Let me try to be a bit more specific here:
I'm basically sending back and forth the ssh-agent packet that has the
following  format:

  uint32           length
  byte             type
  data[length -1]  data payload

(as described on
https://tools.ietf.org/html/draft-ietf-secsh-agent-02#section-1.1)

Any of the internals should _not_ matter, as we don't mess with the
packet (we just deliver it to the client's ssh agent).

>>
>>   toso
>>
>>>  spice.proto | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/spice.proto b/spice.proto
>>> index 0bfc515..eb99742 100644
>>> --- a/spice.proto
>>> +++ b/spice.proto
>>> @@ -1423,6 +1423,9 @@ channel PortChannel : SpicevmcChannel {
>>>  channel WebDAVChannel : PortChannel {
>>>  };
>>>
>>> +channel SshChannel : PortChannel {
>>> +};
>>> +
>>>  protocol Spice {
>>>      MainChannel main = 1;
>>>      DisplayChannel display;
>>> @@ -1435,4 +1438,5 @@ protocol Spice {
>>>      UsbredirChannel usbredir;
>>>      PortChannel port;
>>>      WebDAVChannel webdav;
>>> +    SshChannel ssh;
>>>  };
>>> --
>>> 2.7.4
>>>
>>> _______________________________________________
>>> Spice-devel mailing list
>>> Spice-devel at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
> Best Regards,
> --
> Fabiano Fidêncio