[Spice-devel] [spice-gtk v3 0/7] Modifiers handling change

Frediano Ziglio fziglio at redhat.com
Sat Sep 3 16:10:00 UTC 2016


This patchset change the way modifiers are handled.
The most important patch is the last which do syncronization
when window is focused or unfocused following user interaction.
This reduces spurious key insertion.

Changes since v2:
- added rationale to "Add set_keyboard_lock_modifiers" (Marc-André Lureau);
- rename keyboard-modifiers.* to spice-gtk-keyboard.* (Marc-André Lureau);
- use SPICE_DEBUG for debug (Marc-André Lureau);
- removed gtk-doc style comments (Marc-André Lureau);
- use G_GNUC_INTERNAL when possible (Marc-André Lureau);
- used uppercase for enum and constants (Marc-André Lureau);
- mve os_is_64bit in spice-util.c (Marc-André Lureau);
- update some comments;
- fixed some issue in "Implements set_keyboard_lock_modifiers for Windows"

Frediano Ziglio (7):
  Move code to handle modifier in a specific file
  Add set_keyboard_lock_modifiers
  Avoid too much #ifdef inside set_keyboard_lock_modifiers functions
  Add os_is_64bit utility function
  Implements set_keyboard_lock_modifiers for Windows
  Add can_set_keyboard_lock_modifiers function
  Sync only on focus change

 src/Makefile.am              |   2 +
 src/spice-gtk-keyboard.c     | 588 +++++++++++++++++++++++++++++++++++++++++++
 src/spice-gtk-keyboard.h     |  45 ++++
 src/spice-gtk-session-priv.h |   2 +-
 src/spice-gtk-session.c      | 128 +++++-----
 src/spice-util-priv.h        |   3 +
 src/spice-util.c             |  42 ++++
 src/spice-widget.c           |   5 +-
 tests/Makefile.am            |   8 +
 tests/keyboard-test.c        |  98 ++++++++
 10 files changed, 862 insertions(+), 59 deletions(-)
 create mode 100644 src/spice-gtk-keyboard.c
 create mode 100644 src/spice-gtk-keyboard.h
 create mode 100644 tests/keyboard-test.c

-- 
2.7.4



More information about the Spice-devel mailing list