[Spice-devel] [NSIS] Add Display Version as a postfix to the Display Name.

[Christophe Fergeau]

On Sun, Sep 04, 2016 at 09:07:48AM +0300, Yedidyah Bar David wrote:
> On Fri, Sep 2, 2016 at 9:23 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > Hey,
> >
> > On Thu, Sep 01, 2016 at 05:43:36PM +0300, Yedidyah Bar David wrote:
> >> On Tue, Aug 30, 2016 at 7:26 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> >> > Hey,
> >> >
> >> > On Mon, Aug 29, 2016 at 03:47:44PM +0300, Yedidyah Bar David wrote:
> >> >> From: Lev Veyde <lveyde at redhat.com>
> >> >>
> >> >> This is done, so that the version will be easily visible in the
> >> >> oVirt Manager under the Applications, because the oVirt Guest Agent
> >> >> returns only Display Names, but not the versions.
> >> >
> >> > Seems fairly common to do that for other Windows applications (had to
> >> > check, your description made it sound like you were workarounding an
> >> > OGA bug)
> >> >
> >> > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> >>
> >> OK, anything else before merging? I don't see this yet on the gitlab
> >> repo. Do you want a PR there?
> >
> > Oh, kind of assumed you had commit rights on gitlab and that you would
> > push this yourself.
> 
> I don't. Please give me commit rights if you want to :-)

You should be able to push to gitlab now.

> 
> > Going to do it now.
> 
> Can't see it there.

Ah right, pushed to the wrong remote ;) Should be fine now.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160905/d8c2d7f0/attachment-0001.sig>