[Spice-devel] [PATCH] Added debug filtering to avoid debugger to start when using in production

Oliver Gutierrez ogutierrez at redhat.com
Mon Sep 5 11:08:33 UTC 2016


This change:

-**  display, inputs, and cursor channels.  See main.js for
+**  display, inputs, and cursor channels.  See main.js for

Is because file in repository has a trailing whitespace.

It happened before in another patch I sent but now is when I finally found
the reason.

On Mon, Sep 5, 2016 at 10:48 AM, Oliver Gutierrez <ogutierrez at redhat.com>
wrote:

> ---
>  spiceconn.js | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/spiceconn.js b/spiceconn.js
> index 903f3b0..5123e04 100644
> --- a/spiceconn.js
> +++ b/spiceconn.js
> @@ -23,7 +23,7 @@
>  **      This is the base Javascript class for establishing and
>  **  managing a connection to a Spice Server.
>  **  It is used to provide core functionality to the Spice main,
> -**  display, inputs, and cursor channels.  See main.js for
> +**  display, inputs, and cursor channels.  See main.js for
>  **  usage.
>  **----------------------------------------------------------
> ----------------*/
>  function SpiceConn(o)
> @@ -185,8 +185,8 @@ SpiceConn.prototype =
>
>                  if (msg.type > 500)
>                  {
> -                    alert("Something has gone very wrong; we think we
> have message of type " + msg.type);
> -                    debugger;
> +                    DEBUG > 0 && alert("Something has gone very wrong; we
> think we have message of type " + msg.type);
> +                    DEBUG > 0 && debugger;
>                  }
>
>                  if (msg.size == 0)
> --
> 2.7.4
>
>


-- 
Oliver Gutierrez
Associate Software Engineer - Desktop Management tools
Red Hat
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160905/af69c678/attachment.html>


More information about the Spice-devel mailing list