[Spice-devel] [PATCH qxl-wddm-dod v2 12/25] Rename mspace.c to mspace.cpp

[Frediano Ziglio]

> > On 6 Sep 2016, at 15:07 PM, Frediano Ziglio < fziglio at redhat.com > wrote:
> 

> > > On Mon, Sep 5, 2016 at 9:26 PM, Frediano Ziglio < fziglio at redhat.com >
> > > wrote:
> > 
> 

> > > > Why the rationale was removed?
> > > 
> > 
> 

> > > By mistake, i'll add it back in the next version.
> > 
> 

> > > > By the way this was a workaround for a VS bug, get Visual Studio 2015
> > > > Update
> > > > 1 (actually we are at update 3)
> > > 
> > 
> 

> > > True, however microsoft recommends using visual c++ compiler profile as
> > > it
> > > is
> > > different from the c compiler profile.
> > 
> 

> > Yes, especially if you don't know what you are doing and you don't have a
> > acceptable test suite.
> 
> > I hope that they all don't apply to us.
> 

> Hi Frediano,

> Actually using Microsoft C++ compiler for C files is recommended because it
> performs
> more excessive static checks and produces warnings regarding more potential
> problematic cases.
> And this is definitely a good thing.

> ~Dmitry

Yes... C++ does more strictly checks. This does not means that all C programmers are moving to a C++ compiler! 

Frediano 

> > Frediano
> 

> > > > Nack
> > > 
> > 
> 

> > > > Frediano
> > > 
> > 
> 

> > > > >
> > > 
> > 
> 
> > > > > Signed-off-by: Sameeh Jubran < sameeh at daynix.com >
> > > 
> > 
> 
> > > > > ---
> > > 
> > 
> 
> > > > > qxldod/mspace.c | 2437
> > > 
> > 
> 
> > > > > -----------------------------------------
> > > 
> > 
> 
> > > > > qxldod/mspace.cpp | 2437
> > > 
> > 
> 
> > > > > +++++++++++++++++++++++++++++++++++++++++
> > > 
> > 
> 
> > > > > qxldod/qxldod.vcxproj | 2 +-
> > > 
> > 
> 
> > > > > qxldod/qxldod.vcxproj.filters | 2 +-
> > > 
> > 
> 
> > > > > 4 files changed, 2439 insertions(+), 2439 deletions(-)
> > > 
> > 
> 
> > > > > delete mode 100755 qxldod/mspace.c
> > > 
> > 
> 
> > > > > create mode 100755 qxldod/mspace.cpp
> > > 
> > 
> 
> > > > >
> > > 
> > 
> 
> > > > > diff --git a/qxldod/mspace.c b/qxldod/mspace.c
> > > 
> > 
> 
> > > > > deleted file mode 100755
> > > 
> > 
> 
> > > > > index d0ba123..0000000
> > > 
> > 
> 
> > > > > --- a/qxldod/mspace.c
> > > 
> > 
> 
> > > > > +++ /dev/null
> > > 
> > 
> 
> > > > > @@ -1,2437 +0,0 @@
> > > 
> > 
> 
> > > > > -// based on dlmalloc from Doug Lea
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -// quote from the Doug Lea original file
> > > 
> > 
> 
> > > > > - /*
> > > 
> > 
> 
> > > > > - This is a version (aka dlmalloc) of malloc/free/realloc written by
> > > 
> > 
> 
> > > > > - Doug Lea and released to the public domain, as explained at
> > > 
> > 
> 
> > > > > - http://creativecommons.org/licenses/publicdomain . Send questions,
> > > 
> > 
> 
> > > > > - comments, complaints, performance data, etc to dl at cs.oswego.edu
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > - * Version 2.8.3 Thu Sep 22 11:16:15 2005 Doug Lea (dl at gee)
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > - Note: There may be an updated version of this malloc obtainable at
> > > 
> > 
> 
> > > > > - ftp://gee.cs.oswego.edu/pub/misc/malloc.c
> > > 
> > 
> 
> > > > > - Check before installing!
> > > 
> > 
> 
> > > > > - */
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -#include <ntddk.h>
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -#include "mspace.h"
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -#pragma warning( disable : 4146 ) /* no "unsigned" warnings */
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -#define MALLOC_ALIGNMENT ((size_t)8U)
> > > 
> > 
> 
> > > > > -#define USE_LOCKS 0
> > > 
> > 
> 
> > > > > -#define malloc_getpagesize ((size_t)4096U)
> > > 
> > 
> 
> > > > > -#define DEFAULT_GRANULARITY malloc_getpagesize
> > > 
> > 
> 
> > > > > -#define MAX_SIZE_T (~(size_t)0)
> > > 
> > 
> 
> > > > > -#define MALLOC_FAILURE_ACTION
> > > 
> > 
> 
> > > > > -#define MALLINFO_FIELD_TYPE size_t
> > > 
> > 
> 
> > > > > -#define FOOTERS 0
> > > 
> > 
> 
> > > > > -#define INSECURE 0
> > > 
> > 
> 
> > > > > -#define PROCEED_ON_ERROR 0
> > > 
> > 
> 
> > > > > -#define DEBUG 0
> > > 
> > 
> 
> > > > > -#define ABORT_ON_ASSERT_FAILURE 1
> > > 
> > 
> 
> > > > > -#define ABORT(user_data) abort_func(user_data)
> > > 
> > 
> 
> > > > > -#define USE_BUILTIN_FFS 0
> > > 
> > 
> 
> > > > > -#define USE_DEV_RANDOM 0
> > > 
> > 
> 
> > > > > -#define PRINT(params) print_func params
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -#define MEMCPY(dest, src, n) RtlCopyMemory(dest, src, n)
> > > 
> > 
> 
> > > > > -#define MEMCLEAR(dest, n) RtlZeroMemory(dest, n)
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -#define M_GRANULARITY (-1)
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -void default_abort_func(void *user_data)
> > > 
> > 
> 
> > > > > -{
> > > 
> > 
> 
> > > > > - for (;;);
> > > 
> > 
> 
> > > > > -}
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -void default_print_func(void *user_data, char *format, ...)
> > > 
> > 
> 
> > > > > -{
> > > 
> > 
> 
> > > > > -}
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
> > > > > -static mspace_abort_t abort_func = default_abort_func;
> > > 
> > 
> 
> > > > > -static mspace_print_t print_func = default_print_func;
> > > 
> > 
> 
> > > > > -
> > > 
> > 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160906/adf6ad21/attachment-0001.html>