[Spice-devel] [PATCH qxl-wddm-dod v2 16/25] Remove minimum size restrict for custom resolution.

[Sameeh Jubran]

On Tue, Sep 6, 2016 at 5:07 PM, Frediano Ziglio <fziglio at redhat.com> wrote:

> >
> > From: Sandy Stutsman <sstutsma at redhat.com>
> >
> > ---
> >  qxldod/QxlDod.cpp | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> > index 7e2d7c1..4dcfca3 100755
> > --- a/qxldod/QxlDod.cpp
> > +++ b/qxldod/QxlDod.cpp
> > @@ -4512,11 +4512,10 @@ NTSTATUS
> > QxlDevice::SetCustomDisplay(QXLEscapeSetCustomDisplay* custom_display)
> >      UINT xres = custom_display->xres;
> >      UINT yres = custom_display->yres;
> >      UINT bpp = QXL_BPP;
> > -    DbgPrint(TRACE_LEVEL_ERROR, ("%s - %d (%dx%d#%d)\n", __FUNCTION__,
> m_Id,
> > xres, yres, bpp));
> > +    DbgPrint(TRACE_LEVEL_WARNING, ("%s - %d (%dx%d#%d)\n", __FUNCTION__,
> > m_Id, xres, yres, bpp));
> >      if (xres < MIN_WIDTH_SIZE || yres < MIN_HEIGHT_SIZE) {
> > -        DbgPrint(TRACE_LEVEL_VERBOSE, ("%s: (%dx%d#%d) must be at least
> > (%dxd)\n", __FUNCTION__,
> > +        DbgPrint(TRACE_LEVEL_VERBOSE, ("%s: (%dx%d#%d) less than
> (%dxd)\n",
> > __FUNCTION__,
> >              xres, yres, bpp, MIN_WIDTH_SIZE, MIN_HEIGHT_SIZE));
> > -        return ERROR_INVALID_DATA;
> >      }
> >      m_CustomMode =(USHORT) ((m_CustomMode == m_ModeCount-1)?
> m_ModeCount -
> >      2 : m_ModeCount - 1);
> >
>
> This patch is just changing some logging message.
>
Not true, as it removes the line "return ERROR_INVALID_DATA;" which would
prevent the function from changing the resolution.

>
> Frediano
>



-- 
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Junior Software Engineer @ Daynix <http://www.daynix.com>.*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160906/3223b42d/attachment-0001.html>