[Spice-devel] [PATCH qxl-wddm-dod v2 22/25] Reserved must be set to 0

Frediano Ziglio fziglio at redhat.com
Tue Sep 6 14:23:08 UTC 2016


> 
> According to msdn, "The display miniport driver must set this
> value to 0"
> 
> Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
> ---
>  qxldod/QxlDod.cpp | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index faa7de4..e869578 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -590,12 +590,13 @@ NTSTATUS QxlDod::QueryVidPnHWCapability(_Inout_
> DXGKARG_QUERYVIDPNHWCAPABILITY*
>      pVidPnHWCaps->VidPnHWCaps.DriverRotation             = 1; // BDD does
>      rotation in software
>      pVidPnHWCaps->VidPnHWCaps.DriverScaling              = 0; // BDD does
>      not support scaling
>      pVidPnHWCaps->VidPnHWCaps.DriverCloning              = 0; // BDD does
>      not support clone
> -    pVidPnHWCaps->VidPnHWCaps.DriverColorConvert         = 1; // BDD does
> color conversions in software
> -    pVidPnHWCaps->VidPnHWCaps.DriverLinkedAdapaterOutput = 0; // BDD does
> not support linked adapters
> -    pVidPnHWCaps->VidPnHWCaps.DriverRemoteDisplay        = 0; // BDD does
> not support remote displays
> -
> -    DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__));
> -    return STATUS_SUCCESS;
> +    pVidPnHWCaps->VidPnHWCaps.DriverColorConvert         = 1; // BDD does
> color conversions in software
> +    pVidPnHWCaps->VidPnHWCaps.DriverLinkedAdapaterOutput = 0; // BDD does
> not support linked adapters
> +    pVidPnHWCaps->VidPnHWCaps.DriverRemoteDisplay        = 0; // BDD does
> not support remote displays
> +    pVidPnHWCaps->VidPnHWCaps.Reserved = 0;

Only this line is required, other lines are just space changes

> +
> +    DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__));
> +    return STATUS_SUCCESS;
>  }
>  

Beside that

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list