[Spice-devel] [PATCH qxl-wddm-dod v2 24/25] Removing unnecessary call to BlackOutScreen

[Frediano Ziglio]

> 
> This call to BlackOutScreen is not needed since the actual
> display surface is destroyed and created (redrawn) again.
> 
> Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
> ---
>  qxldod/QxlDod.cpp | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index a085ba5..44989c7 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -1533,14 +1533,12 @@ NTSTATUS QxlDod::SetSourceModeAndPath(CONST
> D3DKMDT_VIDPN_SOURCE_MODE* pSourceMo
>          }
>      }
>  
> -    if (NT_SUCCESS(Status))
> -    {
> -
> -        m_pHWDevice->BlackOutScreen(&m_CurrentModes[pPath->VidPnSourceId]);
> -

Only these 2 lines are changed, other changes are just spaces.

> -        // Mark that the next present should be fullscreen so the screen
> doesn't go from black to actual pixels one dirty rect at a time.
> -        pCurrentBddMode->Flags.FullscreenPresent = TRUE;
> -        for (USHORT ModeIndex = 0; ModeIndex < m_pHWDevice->GetModeCount();
> ++ModeIndex)
> +    if (NT_SUCCESS(Status))
> +    {
> +
> +        // Mark that the next present should be fullscreen so the screen
> doesn't go from black to actual pixels one dirty rect at a time.
> +        pCurrentBddMode->Flags.FullscreenPresent = TRUE;
> +        for (USHORT ModeIndex = 0; ModeIndex < m_pHWDevice->GetModeCount();
> ++ModeIndex)
>          {
>               PVIDEO_MODE_INFORMATION pModeInfo =
>               m_pHWDevice->GetModeInfo(ModeIndex);
>               if (pCurrentBddMode->DispInfo.Width ==
>               pModeInfo->VisScreenWidth &&

Beside that,

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano