[Spice-devel] [PATCH v3 23/28] Support future Qxl revisions

[Sameeh Jubran]

On Wed, Sep 7, 2016 at 5:02 PM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> Hey,
>
>
> On Wed, Sep 07, 2016 at 04:10:41PM +0300, Sameeh Jubran wrote:
> > The driver determines operation mode
> > (QXL or VGA) by checking device hardware
> > ids including revision id field.
> >
> > Without this patch driver operates in VGA
> > mode for all revisions other than 4.
> >
> > This patch makes driver operate in QXL
> > mode revision 4 and newer devices.
>
> Reading this commit log, I would expect only the first hunk to matter. I
> have no idea what the rest of the changes are doing, are they needed to
> achieve what the changelog decribe? (ie attempt to have QXL/VGA working
> with QXL rev > 4)
>
> True, the rest shouldn't be in this commit!
Thanks for pointing that out, I'll fix it.

> Christophe
>



-- 
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Junior Software Engineer @ Daynix <http://www.daynix.com>.*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160907/5f56599d/attachment.html>