[Spice-devel] [PATCH v3 00/28] Win10 support patches

[Christophe Fergeau]

On Wed, Sep 07, 2016 at 06:40:57PM +0300, Dmitry Fleytman wrote:
> 
> > On 7 Sep 2016, at 18:20 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > 
> > On Wed, Sep 07, 2016 at 05:55:31PM +0300, Sameeh Jubran wrote:
> >> On Wed, Sep 7, 2016 at 5:47 PM, Christophe Fergeau <cfergeau at redhat.com>
> >> wrote:
> >> 
> >>> On Wed, Sep 07, 2016 at 04:10:18PM +0300, Sameeh Jubran wrote:
> >>>> Dmitry Fleytman (2):
> >>>>  Introduce end-of-line normalization
> > 
> > So it seems everything was changed from Dos to Unix? What is the
> > rationale for going this way rather than the other way around?
> > I think I would convert all source files to Dos except for the include/
> > ones which are c&p'ed from elsewhere. This would make the diff much
> > smaller, and give us a much less polluted git history.
> 
> Hi Christophe,
> 
> We prefer to have the same EOL style for all files in the repository because
> this way it is much easier to define automatic EOL conversion rules for future commits.

I don't know how you intend to define these automatic EOL conversion
rules, but if this is through git hook + script, having a few exceptions
is probably not that much complicated than single EOL for the whole
repository (but I agree it's less nice).


> LF has a number of advantages over CR/LF so we decided to use it.

Which are ?


> We believe that one big commit that converts EOL characters is an
> acceptable price for future simplicity.

Since this is going to get in the way of git log, git blame, ...
forever, I'd try to minimize the amount of change there is..

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160907/59fe027b/attachment-0001.sig>