[Spice-devel] [RFC] Adding support to ssh-agent-forward

[Victor Toso]

Hi,

On Sat, Sep 03, 2016 at 01:49:06PM +0200, Fabiano Fidêncio wrote:
> Howdy!
>
> Here is a small patch series adding support to ssh-agent-forward.
> This patch series have been tested using a usable (but not 100%
> working) spice-ssh-agent[0].
> 
> The spice-related part seems to be working fine. There are still a
> few improvements to be done on spice-ssh-agent[0[, but that shouldn't
> be a blocker and patches are more than welcome.
> 
> There is also some work done on virt-viewer[1] and there will be some
> work on virt-manager (adding support to add the new ssh-channel to a
> VM).
> 
> I really would appreciate with we can have the spice{,-proto,-common}
> merged before the next release.
> 
> For spice-gtk it can be merged after 0.33 though due to the issues I
> am still having with the spice-ssh-agent[0].
> 
> If you're interested in contributing to the spice-ssh-agent[0], please.
> feel free to send me direct emails with your patches or open a pull
> request on gitlab.
> 
> [0]: https://gitlab.com/fidencio/spice-ssh-agent

Link is broken!

By the way, I was thinking about what is your plan to distribute this
spice-ssh-agent. It could be interesting to have this together with
spice-vdagent, no?

I was thinking about spice-webdavd which we need on guest to make shared
folder work; It stays under phodav library which is shipped in Fedora.
We probably want something similar to spice-ssh-agent, hence my
suggestion.

Cheers,
  toso

> [1]: https://gitlab.com/fidencio/virt-viewer/tree/wip/ssh-agent-forward
>
> spice-proto:
>     Fabiano Fidêncio (1):
>       Add support to ssh channel
>     
>      spice/enums.h | 1 +
>      1 file changed, 1 insertion(+)
> 
> spice-common:
>     Fabiano Fidêncio (1):
>       Add support to ssh channel
>     
>      spice.proto | 4 ++++
>      1 file changed, 4 insertions(+)
> 
> spice:
>     Fabiano Fidêncio (2):
>       spice-common submodule update
>       Associate org.spice-space.ssh.0 port to a ssh channel
>     
>      server/reds.c | 3 +++
>      spice-common  | 2 +-
>      2 files changed, 4 insertions(+), 1 deletion(-)
> 
> spice-gtk:
>     Fabiano Fidêncio (2):
>       spice-common submodule update
>       Add channel-ssh
>     
>      configure.ac                         |  26 ++
>      doc/reference/spice-gtk-sections.txt |  17 ++
>      doc/reference/spice-gtk.types        |   2 +
>      spice-common                         |   2 +-
>      src/Makefile.am                      |   3 +
>      src/channel-ssh.c                    | 454 +++++++++++++++++++++++++++++++++++
>      src/channel-ssh.h                    |  68 ++++++
>      src/map-file                         |   1 +
>      src/spice-channel.c                  |  10 +
>      src/spice-client.h                   |   1 +
>      src/spice-glib-sym-file              |   1 +
>      11 files changed, 584 insertions(+), 1 deletion(-)
>      create mode 100644 src/channel-ssh.c
>      create mode 100644 src/channel-ssh.h
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel