[Spice-devel] [PATCH] Fix marshallers for SpiceMsgPortInit

Victor Toso victortoso at redhat.com
Thu Sep 8 16:23:31 UTC 2016


Protocol states that name is an array of bytes but the marshallers are
considering it a pointer to an array of bytes. A client that does not
use demarshallers from spice-common will find an incorrect
implementation of spice-server SpiceMsgPortInit.

Reported-by: Oliver Gutierrez <ogutierrez at redhat.com>
Signed-off-by: Pavel Grunt <pgrunt at redhat.com>
Signed-off-by: Victor Toso <victortoso at redhat.com>
---
 spice.proto | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spice.proto b/spice.proto
index 0bfc515..08d7152 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1412,7 +1412,7 @@ channel PortChannel : SpicevmcChannel {
  server:
     message {
 	uint32 name_size;
-	uint8 *name[name_size] @zero_terminated @marshall @nonnull;
+	uint8 name[name_size] @zero_terminated @marshall @nonnull;
 	uint8 opened;
     } init = 201;
     message {
-- 
2.7.4



More information about the Spice-devel mailing list