[Spice-devel] [PATCH spice-gtk] display: Do not marshall empty message

[Pavel Grunt]

Hi,

On Thu, 2016-09-08 at 17:45 -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > ---
> >  src/channel-display.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/src/channel-display.c b/src/channel-display.c
> > index 709b3d2..020b7fb 100644
> > --- a/src/channel-display.c
> > +++ b/src/channel-display.c
> > @@ -1816,7 +1816,6 @@ void
> > spice_display_gl_draw_done(SpiceDisplayChannel
> > *display)
> >      channel = SPICE_CHANNEL(display);
> >  
> >      out = spice_msg_out_new(channel,
> > SPICE_MSGC_DISPLAY_GL_DRAW_DONE);
> > -    out->marshallers->msgc_display_gl_draw_done(out->marshaller,
> > NULL);
> >      spice_msg_out_send_internal(out);
> >  }
> 
> 
> It's not obvious to me why it should be removed.
take a look at the marshaller definition, it is empty

https://paste.fedoraproject.org/424219/

> 
> So, I'd rather keep it for completeness. 
> 
It is the only empty message using it