[Spice-devel] [PATCH v3 17/28] Enable HW cursor support

[Frediano Ziglio]

> 
> * Turn on enable pointer
> 
> Based on a patch by Sandy Stutsman <sstutsma at redhat.com>
> 
> Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
> ---
>  qxldod/QxlDod.cpp | 10 +++++-----
>  qxldod/QxlDod.h   |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index 39822f4..a154cd9 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -4478,15 +4478,15 @@ NTSTATUS QxlDevice::SetPointerPosition(_In_ CONST
> DXGKARG_SETPOINTERPOSITION* pS
>                                   pSetPointerPosition->VidPnSourceId,
>                                   pSetPointerPosition->X,
>                                   pSetPointerPosition->Y));
> -    if (EnablePointer()) {
> +    if (!EnablePointer()) {
>          QXLCursorCmd *cursor_cmd = CursorCmd();
>          if (pSetPointerPosition->X < 0) {
>             cursor_cmd->type = QXL_CURSOR_HIDE;
>      } else {
> -           cursor_cmd->type = QXL_CURSOR_MOVE;
> -           cursor_cmd->u.position.x = (INT16)pSetPointerPosition->X;
> -           cursor_cmd->u.position.y = (INT16)pSetPointerPosition->Y;
> -        }
> +        cursor_cmd->type = QXL_CURSOR_MOVE;
> +        cursor_cmd->u.position.x = (INT16) pSetPointerPosition->X;
> +        cursor_cmd->u.position.y = (INT16) pSetPointerPosition->Y;
> +    }

As said this code is never executed and the change contains mainly
space changes.

>          PushCursorCmd(cursor_cmd);
>      }
>      DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__));
> diff --git a/qxldod/QxlDod.h b/qxldod/QxlDod.h
> index a1a4980..16fa78b 100755
> --- a/qxldod/QxlDod.h
> +++ b/qxldod/QxlDod.h
> @@ -448,7 +448,7 @@ public:
>      NTSTATUS SetPowerState(DEVICE_POWER_STATE DevicePowerState,
>      DXGK_DISPLAY_INFORMATION* pDispInfo);
>      NTSTATUS HWInit(PCM_RESOURCE_LIST pResList, DXGK_DISPLAY_INFORMATION*
>      pDispInfo);
>      NTSTATUS HWClose(void);
> -    BOOLEAN EnablePointer(void) { return FALSE; }
> +    BOOLEAN EnablePointer(void) { return TRUE; }
>      NTSTATUS ExecutePresentDisplayOnly(_In_ BYTE*             DstAddr,
>                      _In_ UINT              DstBitPerPixel,
>                      _In_ BYTE*             SrcAddr,

Frediano