[Spice-devel] [PATCH v3 14/28] Code Analysis clean up

[Frediano Ziglio]

> 
> Based on a patch by Sandy Stutsman <sstutsma at redhat.com>
> 
> Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
> ---
>  qxldod/QxlDod.cpp | 471
>  ++++++++++++++++++++++++++++++------------------------
>  1 file changed, 260 insertions(+), 211 deletions(-)
> 
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index 05c6eb9..a6b7d65 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -3,7 +3,7 @@
>  #include "qxl_windows.h"
>  
>  #pragma code_seg(push)
> -#pragma code_seg()
> +#pragma code_seg("PAGE")
>  
>  #define WIN_QXL_INT_MASK ((QXL_INTERRUPT_DISPLAY) | \
>                            (QXL_INTERRUPT_CURSOR) | \
> @@ -61,6 +61,7 @@ QxlDod::QxlDod(_In_ DEVICE_OBJECT* pPhysicalDeviceObject) :

....

This patch contains:
- moved some functions, this IMHO should be removed to make the patch
  smaller;
- space/style changes, this should be removed too;
- better designation of code to go in paged areas and calls to PAGED_CODE
  macro to fix the code analyzer. I would put some words in the comment
  as why PAGED_CODE is used.

Frediano