[Spice-devel] [PATCH v2 03/10] Generate GTypes for spice-server enums

[Jonathon Jongsma]

On Fri, 2016-09-09 at 11:18 +0200, Christophe Fergeau wrote:
> On Thu, Sep 08, 2016 at 09:09:53AM -0500, Jonathon Jongsma wrote:
> > 
> > On Thu, 2016-09-08 at 08:25 -0400, Frediano Ziglio wrote:
> > > 
> > > > 
> > > > 
> > > > 
> > > > Looked at this a bit closer, any reason why this is limited to
> > > > spice-server.h and not including the other public headers? I
> > > > don't
> > > > really understand why we need these enums at this point.
> > > > Also, some of the enums in spice-server.h are not taken into
> > > > account
> > > > because they are not of the form typedef enum { } spice_foo_t;
> > > > 
> > > 
> > > I actually merged all but this... yes, there is no current reason
> > > for
> > > this
> > > patch (as far as I know).
> > > 
> > > Is it used for debugging somewhere in the future?
> > > GObject require it?
> > 
> > 
> > Yes, it's for the coming GObject changes. Basically, if any object
> > has
> > a GObject property with an enum type, we need a GType for that. So
> > that's also the reason for only generating gtypes for the spice-
> > server.h file -- those are the only ones that are required for
> > properties.
> 
> Ah, probably worth adding some small "The GType will be useful when
> we
> use these enums as GObject properties" or such to the log? (this does
> not seem to have been pushed yet to master). Not really important
> anyway
> as this will be obvious in git once the patches using that will be
> merged.
> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Christophe


Yes, will add that to the commit log.